https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42444

--- Comment #40 from Paul Derscheid <[email protected]> ---
Created attachment 206714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206714&action=edit
Bug 42444: (QA follow-up) Submit single cancel through form-submit.js

- The cancel form was built as a JS string with a hand-added CSRF token,
  failing xt/find-missing-csrf.t
- Its inline onclick confirmation was blocked when csp_mode is enforced,
  and a quote in the translated string broke the attribute
- Use a .submit-form-link with data-confirmation-msg instead (JS16)
- Add escape_attr for values inside attributes; escape_str leaves quotes
- Word the modal for the action it confirms (cancel all / selected),
  without jQuery (JS21)

Test plan:
1. prove xt/find-missing-csrf.t
2. Go to Circulation > Holds awaiting pickup
3. Click 'Cancel hold' on a row; a confirmation appears, cancelling it
   keeps the hold, confirming cancels it
4. Select some holds and click 'Cancel selected'; the modal asks about
   the selected holds
5. On the expired tab click 'Cancel all'; the modal asks about all
   expired holds

Assisted-by: Opus 5.5 (Anthropic)
Signed-off-by: Paul Derscheid <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to