https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43654

            Bug ID: 43654
           Summary: Item search: DataTables column filters ignored when 2+
                    conditions are combined (follow-up to Bug 36930)
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]
                CC: [email protected]
  Target Milestone: ---

Bug 36930 fixed item search returning wrong results when 2+ added
conditions were combined, by making the filter constructor in
catalogue/itemsearch.pl detect whether parameters arrived as 'f[]'
(bracket notation, sent by JS when there are 2+ conditions) or plain
'f' (single condition), and read/write consistently.

However, the JSON-preprocessing block that merges DataTables column
filters (free-text search box and dropdowns for library, item type,
etc. in the results table) still unconditionally reads from
multi_param('f') without brackets. With 2+ conditions, that call
returns empty (JS sent 'f[]'), so the column filters get pushed onto
an empty array and written back to the plain 'f' param — which the
filter constructor further down (fixed by Bug 36930) never reads,
since it's looking at 'f[]'. The column filters are silently ignored
and the results table gets stuck on "Processing".

Steps to reproduce:
1. Go to Cataloging > Item search.
2. Add 2 search conditions (e.g. Library = X AND Item type = Y).
3. Run the search, then try to filter further using one of the
   result table's column filters (e.g. type a value in a free-text
   column filter, or pick a value from a dropdown column filter).
4. The column filter has no effect / the table stays on "Processing".

With only 1 condition, column filters work correctly.

Fix: read/write the same 'f[]'/'q[]'/'op[]'/'c[]' vs 'f'/'q'/'op'/'c'
convention in the preprocessing block, detected the same way the
Bug 36930 filter constructor already does (checking for the
bracketed param name among $cgi->multi_param).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to