https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42585

--- Comment #20 from Kyle M Hall (khall) <[email protected]> ---
Created attachment 207243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207243&action=edit
Bug 42585: Add schema-aware and meta analyzers

This patch adds the last two checks:

* select_star_on_large_payload_table, a wildcard SELECT whose plan
  touches one of Koha's big payload tables such as biblio_metadata or
  action_logs, dragging every row's full payload through the database,
  Plack and the download
* explain_failed, emitted when EXPLAIN itself errored, with the
  trimmed database error in the message

Test Plan:
1) Apply this patch
2) prove t/Koha/Reports/Analyzer/Check/SchemaAware/ \
         t/Koha/Reports/Analyzer/Check/Meta/
3) Analyze a report with the SQL "SELECT * FROM biblio_metadata"
4) On a stock dev database, note the select_star_on_large_payload_table
   finding is listed under "Not a problem on this database", with the
   row estimate that decided it!
5) Load enough records that biblio_metadata holds more than 1000, then
   analyze again, note the finding is now a real one!
6) Analyze a report with the SQL "SELECT no_such_column FROM borrowers"
7) Note the explain_failed finding with the database error in it!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to