https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383
Brendan Lawlor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Brendan Lawlor <[email protected]> --- I used Claude Opus 5.5 to test this with ktd proxy running current main and the bug's branch side by side. Most of the things that it caught I was able to confirm. Here's Claude's findings in order of severity with some notes from me: Tested branch bug_42383_vuejs_checkin on KTD against the full test plan, using real data and a headless browser. Most of the plan passes; the problems are below. FAILURES 1. HoldsAutoFill is ignored (test plan 4.6) With HoldsAutoFill on, the hold found modal still appears and the hold is not filled. Nothing in the new code reads the preference. Legacy returns.pl called ModReserveAffect and requested a transfer when needed. - Confirmed with manual human testing 2. Hold cancellation reason is never saved (4.4) HoldCancellationModal.vue binds r.authorised_value, but /authorised_value_categories/.../authorised_values returns "value". The options have no real value, so no reason is sent to hold_cancellation and the cancelled hold has cancellation_reason NULL. - Confirmed with manual human testing using ktd --dbshell after cancelling a hold 3. Wrong transfers are not repaired (5.4) Item in transit MPL -> FPL, checked in at CPL: the "Wrong transfer detected" modal is correct, but the transfer is left as MPL -> FPL. Legacy returns.pl replaced it (request_transfer with replace => 'WrongTransfer', ignore_limits => 1). "Yes, transfer" can't fix it either: the store only calls transfer_confirmation when entry.transfer_id is set, and it is null here. - Confirmed with Manual testing and verifying in ktd --dbshell. My understanding of the legacy checkin is that whe a wrong transfer is detected the original row in branchtransfers should get a datecancelled and cancellation_reason = 'WrongTransfer'. A new branch transfer should be created for the new transfer with the datesent. 4. Bundle "Confirm checkin and mark missing items as lost" does nothing (9.2) verified_bundle_barcodes is in the API spec (paths/checkins.yaml) but no Perl code reads it. With 2 of 3 bundle items scanned, the missing item was not set to BundleLostValue. Legacy did this in returns.pl (and removed unexpected items from the bundle). The Title and Author columns in the verification table are also empty: the component reads biblio_title / biblio_author, which the items response doesn't provide. - Confirmed with manual human testing. Confirm chekcin and mark missing items as lost does not update the item's lost status. Title and Author don't display in the confirm bundle contents table, and 5. "Remove from bundle" does nothing (3.5) The button in the in_bundle alert (Main.vue) has no click handler; onMessagesClick only handles .resolve-claim-btn. "View host item" also links to the checked-in item's own biblio (latest.item.biblio.biblio_id) rather than the host's. - Confirmed with Manual testing, Remove from bundle button does not work and View host item links to the bundled item instead of host 6. "Print checkin slip" opens the quick slip (10.5) slip-printer.js opens circulation.pl?borrowernumber=X&print=qslip. Legacy opened members/printslip.pl?borrowernumber=X&print=checkinslip. - Confirmed with manual human testing. Also this just opened the route in a new windo, not the actual print dialog 7. Patrons with privacy "Never" (10.5) With AnonymousPatron set, the row shows the anonymous patron's name and offers "Print checkin slip" for the anonymous patron. The embedded checkout is already anonymised (privacy 1), so the privacy check never hides the button. - Confirmed with manual human testing. I guess the Anonymous patron name and print checkin slip button should not be displayed in this case 8. Checkout note (issue.note) not shown on a normal return (8.3) The note is in the API response but is only rendered inside ConfirmationModal, so it appears only when a hold/transfer/recall modal opens, and the date is shown as a raw ISO timestamp. Legacy showed the "Patron note" box, with a formatted date, on every return that had one. - Confirmed with manual human testing. It's an ISO timestamp instead of a formatted date, so it's a very minor issue. 9. Circulation sidebar never shows (1.5) checkin.tt still uses Koha.Preference('CircSidebar'), which was removed by bug 42344. All other circ templates now use [% WRAPPER 'main-container.inc' aside='circ-nav' %]. - Confirmed by manual human testing. SMALLER ISSUES - Every normal return gets an "Already returned" badge. It comes from the WasReturned message, which just means the checkout was returned; legacy never displayed it. - Confirmed by manual human testing. It should just say 'Returned' - Hold for another library (4.3): the modal says "Hold at <library>" / "Confirm hold (Y)" rather than "Transfer to" / "Confirm hold and transfer", because the response has no needs_transfer message. The transfer itself is created correctly on confirm. - Confirmed by manual human testing - Ignore (I) on a hold modal marks the row "Not checked in" although the item was checked in (dismissPending is used for post-checkin actions as well). -Confirmed by manual human testing - Re-checking in an item already waiting for a hold (4.5): the modal doesn't say the hold is already waiting (legacy: "Hold found (item is already waiting)"). - Confirmed by manual human testing. No item is already waiting message' - "No, don't transfer (N)" cancels the transfer, but the row still shows "Transferred" and "Transfer to <library>". - Confirmed by manual human testing - Invalid barcode shows "Item not found"; legacy showed "No item with barcode: X". - Confirmed with manual human testing - UpdateNotForLoanStatusOnCheckin: shown only as a raw "not for loan status updated" badge, without the from/to values. - Patron column: the name is not a link and there is no checkouts count (checkouts_count isn't embedded). - Confirmed by manual human testing - When a lost item is returned and a new overdue fine is charged, both "refund applied" and "refund applied and new overdue charge calculated" are shown; legacy showed one (IF/ELSIF). - "Forgive fees for manually expired holds" is emitted by CheckinOptions but never sent by the store. - Koha::Module::Policy::Checkin sets recalls_enabled from preference('UseRecalls') ? 1 : 0, which is true for 'off'. It should compare with ne 'off'. Nothing in the Vue code reads it yet. PASSED - Core flow: scan, barcode clears and refocuses, fast scans processed independently (newest first), not checked out, RecordLocalUseOnReturn. - Options: book drop (warning highlight, fine uses the drop-box date), forgive overdue charges, return date override, "Remember return date", book drop and forgive combined; exempt_fine hidden without updatecharges: writeoff, and a forced request gets a 403 with X-Koha-Module-Policy (payload exempt_fine = 0). - BlockReturnOfWithdrawnItems / BlockReturnOfLostItems blocking modals and the withdrawn warning; UpdateNotForLoanStatusOnCheckin changes the status. - Hold found modal details (patron, category, address, phone, email, SMS, restricted, address in doubt, notification methods, main contact method), confirm (waiting), confirm for another library (transfer created), Print slip and confirm, WaitingNotifyAtCheckin. - Transfers: blocking and non-blocking modals, scanning while a modal is open, print transfer slip, AutomaticConfirmTransfer, transfer arrived, AllowReturnToBranch=homebranch blocking. - Recalls: modal details, confirm (waiting), confirm with transfer (in_transit). - Lost fee refunded / remains / charged, processing fee message, FineNotifyAtCheckin with payment link. - Restriction messages (new, previously restricted, indefinite), return claim warning, resolve claim modal (PUT /return_claims/{id}/resolve), AutoClaimReturnStatusOnCheckin. - CircConfirmItemParts confirm and deny; bundle verification modal UI, progress counter, confirm without verifying, cancel. - Table: TablesSettings column hiding, numReturnedItemsToShow cap, overdue flag, Blocked / Not checked in indicators. - Network error message and retry; the page and the API are refused without circulate_remaining_permissions. - API: GET /checkins/availability (blockers/confirms/warnings, no side effects), POST by item_id and external_id, 412 with confirmation token then 200, 400 without an identifier, 404 for an unknown item; hold_confirmation, hold_cancellation, transfer_confirmation, transfer_cancellation, recall_confirmation. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
