https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Lisette Scheer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|[email protected] |[email protected]
                   |y.org                       |m

--- Comment #172 from Lisette Scheer <[email protected]> ---
The warning for the checkout doesn't specify that it's from the global limit,
it just looks like a matching rule from the global. The only difference on the
message when the global limit is set is that it's for all libraries, but it's
confusing for troubleshooting that it doesn't specify that it's the global
limit. 

Too many checked out. 5 checked out, only 5 are allowed.
Maximum checkouts calculated from the circulation rule for

    Item type: All item types
    Patron category: All patron categories
    Library: Centerville

I tried adding another if to the list after the library:
        [% IF rule.has_prority == "1" %]
        <li>
            Global checkout limit
        </li>
        [% END %]

But I get the following error when I try checking an item out:

Template process failed: undef error - The method
Koha::CirculationRule->has_prority is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 1057
Koha::Object::AUTOLOAD('Koha::CirculationRule=HASH(0x55ecbcfd7538)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 1385


This is what gets dumped out if you dump the rule:
$VAR1 = {
'rule_name' => 'maxissueqty',
'categorycode' => undef,
'branchcode' => undef,
'rule_value' => '5',
'itemtype' => undef,
'has_priority' => 1,
'id' => 54
};

This pointed out to me that we should have tests to cover this use case.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to