http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
--- Comment #146 from Ketan Kulkarni <[email protected]> --- Thank you Srdjan for consolidating the patch and also for removing the if() from utf8::upgrade($some_var) if utf8::is_utf8($some_var); The condition is not needed. Regards, Ketan (In reply to Srdjan Jankovic from comment #145) > I cannot sign off, it has tabs instead of spaces. > > I have replaced the multi-patch with this consolidated one. Please check if > the commit message is ok. > > Also, I don't have time to look deeper, but > utf8::upgrade($some_var) if utf8::is_utf8($some_var); > looks wrong, that should not be needed. Or at least looks like the problem > is being addressed in the wrong place. > > ENCODING => 'utf8' makes sense. > > Encode::decode() would also makes sense I presume. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
