https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142
--- Comment #40 from Emmi Takkinen <[email protected]> --- (In reply to Katrin Fischer from comment #38) > 3) Spelling (Suggestion) > > The code and db use sub_location, but the description for the GUI is > sublocation. > Should we make them match to make things less confusing down the road? I > know we have a lot of these inconsistencies in Koha, but as we are starting > out fresh here it might make sense to avoid one more :) > > description: sub_location for this item > > + `sub_location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the > sublocation for this item', > > <span class="label">Sublocation:</span> > I had a chat with my collegues and we agreed that this has to be changed. Correct term is sublocation. I'll change it and clean up code and schema files while I'm at it. > 4) Frameworks und Koha to MARC mappings (OK) > > This doesn't contain a change to the frameworks or mappings. For existing > installations I believe this is OK, as we only have one lower case subfield > (k) left and we cannot assume that libraries have not been using any lower > or upper case letters in their configurations already. The downside is, that > this means the feature won't be active by default in a new installation, so > we might want to think about some extra good documentation. > I think documentation is good enough. Not everyone will probably want this to be in use by default. > I found one oddity while testing: In order for things to work nicely, you > have to add the subfield definition to the DEFAULT framework. If you don't, > you will have display problems on all pages (sublocation not showing at all > or only showing as code). I initially had only added it to the BKS framework > and all problems in testing resolved, once it was added to Default as well. > This could be something to note in the release notes maybe or in any > instructions for setting this up. > This doesn't seem right, I'll take a look to see what I can do about this. > 5) Authorised value category (Suggestion) > > It could be a good idea to add an empty authorised value category in the > installer files and the database update. It would not 'hurt' and might help > to advertise the feature. > Sounds good to me. > 6) Testing > > d) List of checkins (Problem) > > The sublocation displays, but the location is gone. I believe this could be > due to the missing item_ here: > > - <span class="shelvingloc">[% > checkin.item_location | html %]</span> > + <span class="shelvingloc">[% checkin.location | > html %] [% IF ( checkin.sub_location ) %] ([% checkin.sub_location | html %]) > Will fix. > d) Questions > * Why is the field not added to the OPAC as well? My bad, I have forgot to add this there (we don't use OPAC so it sometimes slips my mind). > * Why is it added to the list of returns, but not to the list of checkouts? Funnily, no one has ever noticed this even thought we have used this for a long time. But I don't think anyone objects if we add this there also. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
