https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43696

Phan Quang Minh <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Phan Quang Minh <[email protected]> ---
Signed off. Both patches applied cleanly on top of the bug 43674 and 43694
patches, on a
Koha 26.05.02 package install, and retested against our third-party
implementation.

What I checked

  - Koha -> us: the supplyingAgencyMessage header now carries
    <timestamp>2026-10-05T10:16:59Z</timestamp>, a valid xs:dateTime in UTC.
Three status messages sent, all accepted.
  - Our compatibility shim logs every correction it has to make to an incoming
Koha
    message. The entry for fixing timestamp format has gone. What is left is
only the hardcoded agency identifier (bug 43695). So of the four workarounds we
started with, three are now covered by patches.

What I did not check

  - Steps 2-7 of your test plan, the 'Ask for retry' flow through the staff
interface.
    I tested the message formatting from the outside rather than driving that
screen.
  - Step 8, prove t/db_dependent/Koha/ILL/ISO18626/Request.t. This is a package
install with no t/ directory or test harness. Same caveat as on 43674 and
43694.

One thing to know when reading my test output

statusInfo.lastChange came out as 17:16:54Z when UTC was 10:16. That is not the
patch.
This instance has no timezone configured for Koha (<timezone> empty in
koha-conf.xml, no MariaDB timezone tables), so dt_from_string treats the bare
database string as UTC.
Feeding the same string "2026-10-05 17:16:54" to dt_from_string:

    default timezone on this box   -> 2026-10-05T17:16:54Z
    Asia/Ho_Chi_Minh               -> 2026-10-05T10:16:54Z   (correct)

so format_date_time converts correctly whenever Koha knows its timezone. I
mention it only so nobody reads that number as a regression.

On bug 43701: you are right that it duplicates this one. I opened it without
having seen 43696. Nothing further needed from my side there.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to