https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42898
Lucas Gass (lukeg) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Lucas Gass (lukeg) <[email protected]> --- Overall, I am not finding any "light-mode regressions", so this is looking nice. I suspect this would have to get pushed at the same time as Bug 42900 and 42901? If not the "bd-theme-toggle" would be quite confusing. This aria-label I don't think will be translatable: + if (toggle) { + toggle.setAttribute( + "aria-label", + `Toggle colour theme (current: ${preference})` + ); + } What is switch-theme.js? It says "Adapted from Bootstrap docs' colour-modes.js". Do we need to add more info. about it/licensing to the About page? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
