https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43754

            Bug ID: 43754
           Summary: EDI invoice receipt does not update item acquisition
                    fields like manual receive does
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]
  Target Milestone: ---

When an EDIFACT invoice is processed, Koha::EDI::receipt_items only assigns a
barcode (from GIR LAC) and applies AcqItemSetSubfieldsWhenReceived. It does not
touch any of the other fields that the manual receive path sets.

Manual receive (acqui/finishreceive.pl) updates every item linked to the
received order with:
  booksellerid, dateaccessioned, datelastseen, price, replacementprice,
replacementpricedate

EDI receipt sets none of these, so items received through an invoice end up
with different data from the same items received by hand: no source of
acquisition, an accession date that is still the order date, and no price or
replacement price.

Reproduced on main with a vendor EDI account (no plugin), a basket with
create_items=ordering, an order for 2 copies each with a linked item
(dateaccessioned 2020-01-01), and an INVOIC for the 2 copies carrying matching
GIR+LLO segments:
  - order becomes complete, quantityreceived 2
  - items: booksellerid NULL, dateaccessioned still 2020-01-01, price NULL,
replacementprice NULL

Expected: the same item fields as a manual receive, using the invoice date as
the received date, the vendor of the basket and the invoiced/replacement prices
of the received order.

Note this is separate from Bug 42890 (creating items when
AcqCreateItem=receiving).

Test plan:
1. Create a vendor with an EDI account (no plugin) and a basket with
AcqCreateItem=ordering. Add an order line for 2 copies so that 2 items exist.
2. Import an EDIFACT invoice for that order (RFF+LI with the order number,
QTY+47:2, MOA+203/MOA+128) and process it.
3. Without the patch: the items have no booksellerid, an unchanged
dateaccessioned, and empty price and replacementprice.
4. With the patch: the items have the vendor as booksellerid, dateaccessioned
and datelastseen set to the invoice date, price set from the received unit
price, and replacementprice/replacementpricedate set as in a manual receive.
5. Repeat with a partial receipt (invoice 1 of 3) and confirm only the received
items are updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to