https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41713
--- Comment #12 from Janusz Kaczmarek <[email protected]> --- (In reply to Marcel de Rooy from comment #8) > Changes in the first patch look good to me. Have my doubts on the second > patch. > > + t::lib::Mocks::mock_preference( 'SearchEngine', 'Elasticsearch' ); > During this subtest, this pref was mocked to Zebra before. Should it be set > back? Not sure.. > What about the mocks for doing a search on Elastic? You cant really query a > search engine here. (You are calling search_compat. See the mocks for Zebra.) > And if we are mocking those routines, what is still the use of this test? > > Can we do without the second patch? We have discussed the case during KohaCon26. Rebased; setting back to SO. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
