https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41921
--- Comment #119 from Lucas Gass (lukeg) <[email protected]> --- Other problems Brendan pointed out to me: 4. Failed background reports show no error on the admin background jobs page. - Where: includes/background_jobs/run_report.inc:23 - Why: the include loops over m.error.pairs, which expects a hash with keys like sqlerr and queryerr. RunReport::process stores error as a plain string with codes like execute_error and report_not_found, so the failure details never appear. 5. "Run with template" loses the template. - The "how would you like to run this report?" form (choose_run_mode in guided_reports_start.tt) has no hidden template_code field. A user with both permissions who picks a template ends up with a plain run. - The background path ignores template_code entirely: enqueue only passes the report id and parameters. 6. Old limit-handling code is now dead. - prep_report no longer throws DuplicateRunning, TotalRunning or InstanceTotalRunning, but guided_reports.pl (around lines 805 and 1218), svc/report and opac/svc/report still catch them. - One branch also still uses the old total_running_reports_limit_exceeded key (guided_reports.pl ~1222). - Either remove these branches and the unused exception classes in Koha/Exceptions/Report.pm, or keep them on purpose. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
