https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453
--- Comment #24 from Konstantinos Daskalopoulos <[email protected]> --- (In reply to Marcel de Rooy from comment #23) > (In reply to Konstantinos Daskalopoulos from comment #22) > > Happy to move this to a separate follow-up bug if you'd prefer to keep the > > revert discussion here -- just let me know. > > Did you see the fix on bug 42920? Since you make much more changes, the > question comes up if we might need some of your additional changes too ? Thanks Marcel, yes — I had a look. Bug 42920 fixes a different code path: it only reverts the Advanced editor ([% IF rancor %]) block of blinddetail-biblio-search.tt. It doesn't touch the regression from comment 21, which is in the regular cataloguing editor. That regression is still present on current main and 26.05.x. Under UNIMARC, authid_subfield is only declared inside [% IF ( source == 'auth' ) %] / [% ELSIF ( source == 'biblio' ) %] (blinddetail-biblio-search.tt, lines 173-176), with no fallback. The "Create new authority" (+) button in the authority finder doesn't pass source, and authorities.pl doesn't forward it in the redirect to blinddetail-biblio-search.pl. So after saving a new authority from the biblio editor, authid_subfield is undefined, the popup hangs, and $9 is never filled. The two patches don't overlap: 42920 changes the rancor block (~line 40), mine changes the regular-editor branch (~line 169). Mine still applies cleanly on main with 42920 in. What each part of my patch does: - blinddetail-biblio-search.tt: declares authid_subfield unconditionally — "3" only for UNIMARC authority-to-authority linking, "9" otherwise. This alone fixes the crash and gives the right $9 for biblio linking. - auth_finder.tt + auth-finder-search.js + authorities.pl: pass source through the "Create new authority" flow, so a new authority created from the authority editor is linked into $3 (UNIMARC), not $9. If you'd prefer something smaller, I can split it into the template change only (minimal, easy to backport) and a separate patch for the source propagation. Since 21453 is already pushed, I'm also happy to move this to a new bug that depends on 21453, so it can go through sign-off/QA normally — just tell me which you prefer. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
