https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Pedro Amorim (ammopt) <[email protected]> --- Thanks! 1, 2 and 5 look good now. Finding 4: still leaks messages: 1) Give a Fairfield staff user (ffl) only 'catalogue', 'list_borrowers' and 'edit_borrowers'. 2) As koha, set library to Fairfield and add a note on patron 51 (Centerville). 3) As ffl, the staff interface blocks patron 51, but the API shows the note: curl -s -u ffl:<password> 'http://localhost:8081/api/v1/messages?patron_id=51' Finding 3: the problem isn't that it doesn't save, it's that it returns 200, which means the update succeeded when it didn't. This happens when PATCHing an empty message, and now also when PATCHing library_id to null, because Koha::Patron::Message::store silently skips saving if any of borrowernumber, message, message_type or branchcode is empty. It should return a 400 with an error instead. Also, the file message_put.yaml shouldn't be needed: mark message_date as readOnly: true in message.yaml instead. That also stops POST from setting it, which it still allows. Please put it back to PQA after following up so it goes back into my queue. Thanks in advance! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
