https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41932
--- Comment #80 from David Cook <[email protected]> --- (In reply to Marcel de Rooy from comment #79) > Hmm. Given the last comments, we are stuck here again. Just for now I think. I really would like to add this functionality for several of my libraries. I want to work together to get this functionality into Koha one way or another. > the whole ClassSource stuff > is already a kind of pre-plugin approach. I agree. It already is modular, but it's hard-coded to only the 3 existing modules. > Adding plugin hooks inside that > code feels weird too. I agree that it feels weird... but only in the context that we've used Koha plugins to date. In Bug 42870 I used a factory pattern which allows for "core plugins" and "Koha plugins". In the case this bug 41932, the core plugins would be Dewey.pm, Generic.pm, and LCC.pm. The Koha plugin hook would then just be to add classes or objects to the factory options. The factory options could be advertised on /cgi-bin/koha/admin/classsources.pl?op=add_sort_rule in the "Filing routine" dropdown/select menu. We could also add another field like "Configuration parameters" or something like that, and that's where the configuration could live instead of the "ClassSortGenericFormats" global system preference. > So it seems that this will be local customization again ;) Note that I am > running this code in production for months already.. Alternatively... if we didn't want to go the Koha Plugin route, let's create a new ClassSource module in these patches (perhaps "GenericZeroPad") and add that "Configuration parameters" column to the class_sort_rules table. -- Part of my thinking here related to the current conversations going on about system preferences and where system preferences should live for certain functionality. This feels like an area that would benefit from having the configuration closer to the functionality rather than at the global system preference level I think. It would also be more functional, because you could have multiple different filing rules with "GenericZeroPad" with different configuration appropriate to that particular rule. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
