https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41162

--- Comment #8 from Andrew Fuerste-Henry <[email protected]> ---
Created attachment 207824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207824&action=edit
Bug 41162: Don't allow strings of different length

We already have a validator function to prevent this, however, it just returns
'true' in most cases
when I believe it is meant to return the variable 'result'

This won't prevent the letter cases highlighted in the comments, but as library
barcodes are generally
a fixed length it seems reasonable to at least restore this intention

Note: In the cases where the inputs start with '0' we do some handling, but it
seems only to be clearing previous errors?

To test:
1 - Browse to Cataloging->Label Creator->Print barcode range
2 - Enter
    From: 1
    To: 10
3 - Form is submitted
4 - Apply patch
5 - Reload the 'Print barcode range' page:
http://localhost:8081/cgi-bin/koha/labels/label-edit-range.pl
6 - Enter
    From: 1
    To: 10
7 - You are prevented from submitting
8 - Try any different length values - you are prevented

Signed-off-by: David Nind <[email protected]>
Signed-off-by: Philip Orr <[email protected]>
Signed-off-by: Andrew Fuerste Henry <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to