https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35052
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #26 from David Nind <[email protected]> --- I'm not sure if I'm testing this correctly, but here is what I found (testing this bug before testing bug 43355): 1. Search results in the staff interface and OPAC don't show the newly created record when searching for test (or TEST): - This is with items not hidden or with one item withdrawn - Rebuilt the index using: koha-elasticsearch --rebuild -d -b -a kohadev - Not sure where the rebuild in the test plan is different - Sufficient time allowed for index to update (but rebuilt as well) - Also used as per the test plan: misc/search_tools/rebuild_elasticsearch.pl -a -r -v 2. I get a page not found when searching or directly accessing created record: Sorry, the requested page is not available Error 404 - If the record doesn't exist (or is hidden) shouldn't it be no results found, instead of a 404? For example, search for DITA: No results found! No results found for that in catalog. - If you access the record directly with all items hidden, then I would expect a page not found (the number for a new record created in KTD is 439): /cgi-bin/koha/opac-detail.pl?biblionumber=439 - Search results, with one item withdrawn and the other available - search for test or TEST: does not show up the search results (there are three other records) 3. Tests fail for t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t - can fix by changing 12 to 13: .. 1/12 # Looks like you planned 12 tests but ran 13. Testing notes (using KTD and ES9): 1. Apply the patches, including dependent bugs: - Rebuild everything (not sure if this is required or not): yarn build - Restart everything: restart_all - Rebuild the index: koha-elasticsearch --rebuild -d -b -a kohadev 2. Run through the test plan for the patch: Add end-to-end test for the query-time OpacHiddenItems filter - Step 5 (as per wiki) for OpacHiddenItems (no changes required to a standard KTD instance for OpacHiddenItemsHidesRecord and OpacHiddenItemsExceptions): withdrawn: [1] - Step 9: Get a page not found when searching or directly accessing: Sorry, the requested page is not available Error 404 . If the record doesn't exist (or is hidden) shouldn't it be no results found, instead of a 404? For example, search for DITA: No results found! No results found for that in catalog. . If you access the record directly with all items hidden, then I would expect a page not found (the number for a new record created in KTD is 439): /cgi-bin/koha/opac-detail.pl?biblionumber=439 . Search results, with one item withdrawn and the other available - search for test or TEST: does not show up the search results (there are three other records) 3. Run through the test plan for patch: Pass the searching patron into build_query_compat for OpacHiddenItemsExceptions 4. Run through steps 1 and 2 of the test plan for patch: (QA follow-up) Fix perlcritic and POD coverage findings -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
