http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824
--- Comment #7 from David Cook <[email protected]> --- (In reply to Srdjan Jankovic from comment #6) > Not nitpicking or anything, just curious: why adding T...Z string just to > strip it off? Wouldn't it be better to do something on the lines of > > $arg = length($date_string) == 10 > ? ($date_string .= " $time_string") # 00:00:00 or 23:59:59 > : _strip_UTC_designators($date_string); Fair question. I'm adding T...Z string, because it's only stripped off half the time. If you read through the code, you'll see that "from" and "until" properties retain the T and Z designators. It's only the "from_arg" and "until_arg" properties that have them stripped off. The reasoning here is that the "from" and "until" properties are used to generate the actual resumption token, which requires the T and Z designators, while the "from_arg" and "until_arg" have them stripped off for matching in MySQL. Does that make sense? We want the T and Z for the token, but no T and Z for the database. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
