https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608
Frédéric Demians <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |[email protected] --- Comment #70 from Frédéric Demians <[email protected]> --- First : very nice improvement! Second: 14 patches is a lot. Arthur, when you rework the patches for the QA issues, could you also squash them into a few logical patches? The 14 patches tell the story of the development, not the final result. It's complicated to follow... Everything works as described. With the AND/OR logic, between links and check boxes, mimicking Primo. Some remarks: 1. Apply removes the double quotes from the search terms. "de la" => de la It wasn't the case, and so it changes the result. 2. The display changes even with MultiChoiceFacets disabled: . "Refine your search" => "Filters" . The currentlibrary class (facet of the logged in library) is no longer used in facets.inc. 3. In facets.inc: [% SET title="Remove facet " _ facet.facet_label_value | html %] "Remove facet" is not picked up by the translation tools, and the value is escaped twice (in the SET and in the title attribute). 4. In opac-facets.inc: . The | url filter was removed when building local_url, so facet values with &, # or + give broken links. . The Apply <li> elements are inside the <form>, not inside a <ul>. 5. QA script: FAIL installer/data/mysql/atomicupdate/bug41608_multichoicefacets.pl file_permissions: File must have the exec flag forbidden_patterns: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) WARN installer/data/mysql/mandatory/sysprefs.sql sysprefs_order: MultiChoiceFacets is not in alphabetical order About choosing between AND and OR. Nothing tells which operator is used, and two similar actions give opposite results. That is what could make it confusing. Even if the OR between same facet type is a good choice. A AND wouldn't make sense (imho). I would suggest, when MultiChoiceFacets is enabled, to show the active filters in words above the results, each with its own remove link, for example: Active filters: Authors: Austen, Jane OR Beckett, Samuel [x] AND Holding libraries: Centerville [x] [Clear all] The logic is then visible. And there is a bonus: the [x] links are no longer needed in the facet list, where the checked boxes already show the state. ~ -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
