https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43269
--- Comment #29 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Jonathan Druart from comment #27) > (In reply to Tomás Cohen Arazi (tcohen) from comment #26) > > (In reply to Jonathan Druart from comment #25) > > > Did you see bug 36350? > > > > I hadn't. This is much more specific. > > There is also bug 32476. > > > It just felt too weird adding `use > > C4::Biblio` in the classes I was introducing. > > I don't understand what you mean here. > > > My point is that there are already 2 attempts at caching in L1 the result of > extensive or widely used/called methods. The description_for solution you > are suggesting here is indeed very (too) specific. We should aim for a more > global and reusable solution. What the 2 other bugs are suggesting. I've read both bugs and their code. Besides my opinion on the approaches, I believe my implementation is a sound and useful refactoring of an already widely used method `C4::Biblio::GetAuthorisedValueDesc`, and makes it more useful! I just found the need for this on bug 42503, which will loop through holds queue items and query for the item type descriptions and -in the worst case, all items in a resultset different item type- it would mean N DB hits for N results. And `GetAuthorisedValueDesc` is much more efficient, and so this refactoring! I'm all for the other devs where it makes sense, but that's too much scope for this tiny refactoring which will still be needed IMHO. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
