https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43249

--- Comment #16 from Marcel de Rooy <[email protected]> ---
I was looking at this report at the end of the KohaCon. And I was not convinced
by the unit tests.

We mock the sub running by something that looks overcomplicated. In a number of
cases we could just return 1 || true or return e.g. 3 for prep_report()
total_running_reports_per_instance_limit, etc.

Or you could argue that we are actually only testing our mocked routine since
it is too hard to test the real running sub.
But that does not make much sense? Yeah, 5 > 3. But we knew that, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to