https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42621
--- Comment #99 from Matt Blenkinsop <[email protected]> --- Created attachment 208804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208804&action=edit Bug 42621: (QA follow-up) Add LimitReportsBy to sysprefs.sql and fix the atomic update sysprefs.sql still listed LimitReportsByLibrary, so a fresh install had no LimitReportsBy row. get_saved_reports then compared an undefined preference value and crashed on the saved reports list with "Can't call method unblessed on an undefined value". check_sysprefs.t also failed with "Too many sysprefs in DB: LimitReportsBy". The atomic update also set options and type on the renamed preference. Since bug 41834 these columns must be NULL in the database, the YAML file owns them. The update now only renames the variable and converts the value. The stale preference name is also replaced in Reports/Guided.t. Test plan: 1. grep -n "LimitReportsBy" installer/data/mysql/mandatory/sysprefs.sql shows ('LimitReportsBy','none') 2. In ktd --shell: updatedatabase && restart_all 3. koha-mysql kohadev -e "SELECT variable, value, options, type FROM systempreferences WHERE variable = 'LimitReportsBy'" shows value none and NULL for options and type 4. prove t/db_dependent/check_sysprefs.t 5. Open the saved reports list, it loads without error Co-Authored-By: Claude Fable 5.1 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
