https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42623

Pedro Amorim (ammopt) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #30 from Pedro Amorim (ammopt) <[email protected]> ---
Hi all, a couple issues here worth addressing:

Setup
1) Set 'LimitReportsBy' to 'Library':
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=LimitReportsBy

Blocker 1: only parameters labelled 'Library' are enforced
1) Create a new SQL report at
http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?op=add_form_sql
with:
   SELECT branchcode, branchname FROM branches WHERE branchcode =
<<Branch|branches>>
   In 'Library limitation', pick Centerville only, and save
2) Run it. The 'Branch' dropdown only offers Centerville. Click 'Run the
report'
3) In the address bar, change 'sql_params=CPL' to 'sql_params=FPL' and load it.
Fairview is returned, no 'Access denied'
4) Edit the report and change <<Branch|branches>> to <<Library|branches>>.
Repeat steps 2-3: now you get 'Access denied'
prep_report only checks params whose label is exactly 'Library', while the
dropdown filter keys on the 'branches' authorised value. Labels are free text,
so checking the authorised value (minus any :in/:all option) would cover every
library parameter.

Blocker 2: multi-select library parameters are always refused
1) Create a new SQL report with:
   SELECT branchcode, branchname FROM branches WHERE branchcode IN
<<Library|branches:in>>
   In 'Library limitation', pick Centerville and Fairview, and save
2) Run it. The 'Library' list offers Centerville and Fairview. Select both and
click 'Run the report'
3) You get 'Access denied: The selected library is not available for this
report', although both are allowed
4) Select only Centerville and run it again. It works
A multi-select sends the selected codes as one value joined by newlines, so it
needs splitting on "\n" before checking each code.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to