https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859
David Gustafsson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #80 from David Gustafsson <[email protected]> --- (In reply to David Nind from comment #76) > Thanks for the updated patches! > > I've Failed QA because of these things (using KTD and the sample data): > > 1. Although I'm not doing QA, the qa script has several fails and warnings - > mainly > tidy issues. See the list of qa script fails and warnings at the end.[1] > > 2. System preference name and options: > - Suggestion: rename EnableElasticsearchSearchResultExport to just > ElasticsearchSearchResultExport > Rationale: I always find it weird when "Enable" is in the system > preference name, where it is also in the options. Apart from this, I > think the > system preference names should be the feature name (like most are), > with > the options determining if it is enabled or not. > - Options: we normally use Enable/Disable, not Enable/Don't enable. > > 3. System preference ElasticsearchSearchResultExportLimit: for me, this > seemed to > have no effect. Setting to 5, and searching for "cat" (12 search results) > - all 12 results were exported. > Should the default be 0 or empty (I think from other system preferences, > it > is normally left blank to ignore, but I'm not sure. > > 4. ElasticsearchSearchResultExportCustomFormats - used examples in > the system preference notes: > > Title and author: search for "Austen" - not sure why all the | are there: > > "Novels.|Selections|Lady Susan ; The Watsons ; Sanditon /|Penguin English > library|Lady Susan.|Watsons.|Sanditon.","Austen, Jane,|Jane Austen : edited > with an introduction by Margaret Drabble.|Drabble, Margaret," > "Novels|The complete novels /| complete novels /","Austen, Jane,|Jane > Austen ; introduction by Karen Joy Fowler." > > Biblionumbers: same as above: > 283 > 19 > > 5. Download messages/user interface. I'm not a fan of the interface, but I > don't > have any suggestions. May be it should have a coloured background using > the > alerts/information message styling. Maybe tidying this up could be a > separate > follow-up bug. Example: > > Exporting records, the export will be processed as soon as possible. > > 100% Finished > View detail of the enqueued job > > Export finished successfully: > > Biblionumbers: /cgi-bin/koha/tools/upload.pl?op=download&id=4 > > QA script fails and warning > =========================== > > Result: > [FAIL] Koha/BackgroundJob/SearchResultExport.pm > FAIL forbidden_patterns > forbidden pattern: Use https:// instead of http:// for URLs > (line 16) > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > Koha/BackgroundJob/SearchResultExport.pm` > [FAIL] Koha/SearchEngine/Elasticsearch.pm > WARN spelling > origial ==> original > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > Koha/SearchEngine/Elasticsearch.pm` > [FAIL] Koha/SearchEngine/Elasticsearch/Search.pm > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > Koha/SearchEngine/Elasticsearch/Search.pm` > [FAIL] catalogue/search.pl > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > catalogue/search.pl` > [FAIL] > installer/data/mysql/atomicupdate/bug_27859- > add_enable_search_result_marc_export_sysprefs.pl > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > installer/data/mysql/atomicupdate/bug_27859- > add_enable_search_result_marc_export_sysprefs.pl` > [WARN] installer/data/mysql/mandatory/sysprefs.sql > WARN sysprefs_order > Not blocker: Sysprefs > ElasticsearchSearchResultExportCustomFormats is > badly placed (see bug 10610) > [FAIL] > koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ > search_result_export.inc > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/ > search_result_export.inc` > [SKIP] > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref > SKIP new_line_at_the_end_of_file > [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt` > [FAIL] t/db_dependent/Koha/SearchEngine/Elasticsearch.t > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > t/db_dependent/Koha/SearchEngine/Elasticsearch.t` Thanks for the feedback. I just assumed it was tidied since I thought the git hooks would have caught that, but apparently not. Point taken regarding (2), there currently seems to be a mix between the two regarding other settings, and I think it's nice from a developers perspective to know which variables just enable/disable a certain feature, but in the interface it certainly stands out in a bad way. And since it's not consistent anyway I also prefer to leave it out. About (3), I think it has worked at some point, but perhaps not. I refactored that bit anyway as size seems to be ignored for the scroll endpoint, and now it should work. And regarding (4), I think the pipe in those cases where just part of the data, from what I can see. There should be no deliberate insertions of pipes, and "," is used as a separator. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
