https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42835
Adolfo RodrÃguez Taboada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #86 from Adolfo RodrÃguez Taboada <[email protected]> --- Hi Martin and Luis, Two of the fixes in this branch are now separate bugs against main, so they can drop out of the split: Bug 43879 (Needs Signoff): AddReturn does not reindex the record when a withdrawn item blocks the return after clearing onloan. Same fix as commit 30 (piece 1). Bug 43885 (Signed Off): Elasticsearch: sorting on a field without a sort mapping makes the whole search fail. It covers what commit 22 (piece 3) fixed, and also sorts on the .raw/search field when the field is mapped but not sortable. Neither needs the rest of the branch, and the remaining commits apply without them, so I've only added "See also" links, not dependencies. About wrapping index_records in try/catch (from your review): in Bug 43879 the new call follows the same pattern as the existing Wrongbranch early return in AddReturn, which is not guarded either. When index_records is called without records, it only enqueues an update_elastic_index job, and Koha::BackgroundJob::enqueue already catches message broker errors (the job stays in the database). So an Elasticsearch failure cannot reach AddReturn there; only a database error could, and that would have broken the previous writes too. If guarding is wanted, I think it would be better as a separate bug covering all the index_records calls in AddReturn consistently. Have a nice day. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
