https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42898
--- Comment #13 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Andrew and Lucas. Checkmarks: confirmed, nothing hid the active marker so all three icons were always visible. It is now hidden by default and only shown on the selected option. aria-label: good catch. The label is now built with __x() in switch-theme.js using the translated option text, and the static strings and option labels in header.inc are marked translatable too (with translator context on the Light/Dark/Auto labels). Dependencies: yes, this patch is foundations only. Only the base surfaces flip here, and 42899/42900/42901 migrate the components. Light mode is unchanged, so it is safe on its own, but the toggle makes most sense once those land. switch-theme.js: it is an adaptation of the colour-mode toggler from the Bootstrap docs. That script is licensed CC BY 3.0 (the Bootstrap library itself is MIT, already credited on the About page). I have added the copyright and licence lines to the file header and a "Bootstrap colour modes" entry to the About page. Follow-up patch attached. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
