https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42418
--- Comment #115 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 209002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209002&action=edit Bug 42418: (QA follow-up) Keep AddReturn message-content assertions in sync with the new return arity Wiring Koha::Checkin into AddReturn changed its return list from 4 to 5 elements. Three is_deeply assertions on the full return list broke as a result and were weakened down to bare is($doreturn, 0, ...)/ single-key checks instead of being updated for the new arity - losing their ability to catch corruption of $messages content. Update them to slice to the first four elements instead (matching the pattern already used elsewhere in this file for the same reason), and add a Koha::Checkin isa_ok check on the 5th element where a checkin record is expected. Test plan: 1. prove t/db_dependent/Circulation.t => SUCCESS: 90 tests pass. Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Tomás Cohen Arazi <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
