http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131
--- Comment #56 from Katrin Fischer <[email protected]> --- Ok, posting my complete testing notes here for reference: Passes all tests and QA script. 0) Database changes done by updatedatabase and in kohastructure match. 1) Patch touches core routines in C4::ImportBatch.pm , but doesn't provide regression tests: - BatchCommitRecords - BatchCommitItems - BatchRevertRecords 2) Regression test: stage_file.pl and commit_file.pl command line scripts Note: Adding items works as before, new options for item overlay should be added to stage_file.pl later on, but we need to make sure there are no regressions. Staging file: ./stage_file.pl --file ../../data/Katrin-biblios.mrc --add-items --comment "something" --match 3 Committing staged records to catalog: ./commit_file.pl --batch-number 2 Reverting bath import: ./commit_file.pl --revert --batch-number 2 PROBLEM: The summaries are not correct regarding the numbe rof items with the patch applied Without patch: MARC record staging report ------------------------------------ Input file: ../../Downloads/bib-4.utf8 Record type: biblio Number of input records: 1 Number of valid records: 1 Number of invalid records: 0 Number of records matched: 1 Number of items parsed: 4 With patch applied: MARC record import report ---------------------------------------- Batch number: 7 Number of new records added: 0 Number of records replaced: 1 Number of records ignored: 4 Number of items added: 0 Number of items ignored: 0 3) Regression test: Authority import Authority staging and importing works, no regressions found. I noticed that item processing options are offered on the managed MARC imports page, but this has already been reported as bug 9067. 4) Bibliographic records import Tried different options for importing: - Always add items. Still adds items, when the barcode doesn't exist in the database. If barcode already exists, no item is added. - Ignore record if there is a match, but replace items. Record is ignored, item gets replaced. * Delete item with the itemnumber in the import file. PROBLEM: - Replace incoming record on match, replace items. Item will not be created, but summary gives a wrong positive: Number of items replaced 1 We should either create the item with a new itemnumber in that case, or give a proper error message. So 2 smaller problems, but overall it seems to work quite well. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
