https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
--- Comment #489 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 209328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209328&action=edit Bug 33260: (QA follow-up) Use the 'printed' status, print consistently Following the feedback on the bug: * Printing a notice is not sending it. Notices that are printed from the notices pages are now set to 'printed', not 'sent', and so are those printed by gather_print_notices.pl. The delivery note no longer shows the from/to/cc addresses of an email that was only printed. Marking a notice as printed is logged when NoticesLog is enabled. * The patron Notices tab and Notices management now follow the same rule, Koha::Notice::Message->can_be_printed, also enforced by print_notice.pl: notices that are not pending can be printed, and so can pending print notices (to replace the cronjob), but not pending email or sms, which would stop them from being sent. * The "Library" filter of Notices management filters on the library of the patron, not the one the notice comes from: say so, and hide the filter when the notices of the patrons of a single library can be seen. To test: 1. Run the unit tests inside KTD: ktd --shell --run 'prove t/db_dependent/Koha/Notice/Message.t' 2. Enable NoticesManagement and NoticesLog and queue notices of different types: an email and an sms that have been sent or have failed, and pending email and print notices. 3. In Tools > Notices management and on the patron's Notices tab confirm that the same notices can be printed, but not the pending email. 4. Print a sent email notice. Its status is now 'printed', no from/to is shown in its delivery note, and the printing is in the log viewer (module Notices, action PRINT). 5. Run misc/cronjobs/gather_print_notices.pl on pending print notices and confirm they are set to 'printed'. 6. As a staff member whose patron data is limited to one library, confirm the "Patron library" filter is not displayed. 7. Sign off Co-Authored-By: Claude Sonnet 5.5 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
