https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129

--- Comment #313 from Matt Blenkinsop <[email protected]> ---
Created attachment 209509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209509&action=edit
Bug 41129: (QA follow-up) Fix quick modal close

- Bootstrap ignores hide() while the show transition runs, so closing
  the modal right after opening it tore the form down but left the
  modal visible and never emitted close
- Keep the requested open state and apply it once Bootstrap's
  transition events report the animation finished
- Treat any hide, including Escape, as a close request; reopening
  while the modal hides shows it again instead of closing the new
  session
- Add component tests with a stub that, like Bootstrap, ignores
  show() and hide() mid-transition

Test plan:
1. Run: yarn cypress run --component --spec
   t/cypress/component/BookingModal_spec.ts
2. Confirm it passes; without this patch the two new tests fail
3. Open the booking modal and click Cancel immediately, before the
   fade-in finishes
4. Confirm the modal closes

Assisted-by: Opus 5.5 (Anthropic)
Signed-off-by: Paul Derscheid <[email protected]>
Signed-off-by: Matt Blenkinsop <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to