https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #76 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 209542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209542&action=edit
Bug 24401: (QA follow-up) Declare interface in checkin API response, stop
hiding timestamp

checkin.yaml sets additionalProperties: false but never declared the
real 'interface' column that Koha::Checkin->to_api emits, so every
successful POST /checkins response failed OpenAPI response validation
and the endpoint returned a 500 for every caller. Declare it.

Separately, Koha::Checkin::to_api_mapping mapped 'timestamp' to undef,
which Koha::Object treats as "delete this field" - so the documented
timestamp property could never actually appear in a response. There's
no reason to hide it (it's the checkin's own date/time, not
incidental audit metadata), so drop the override and let it serialize
normally (Koha::Object's generic datetime handling already formats it
as RFC3339).

Test plan:
1. yarn build && restart_all
2. prove t/db_dependent/api/v1/checkins.t
=> SUCCESS: passes (previously failed with a 500 on every successful
   checkin).

Signed-off-by: Martin Renvoize <[email protected]>
Signed-off-by: Brendan Lawlor <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to