https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41273

--- Comment #5 from Martin Renvoize (ashimema) 
<[email protected]> ---
Thanks Katrin, and Joubu for the review. You are right, we don't need it: a
forked child inherits the working directory of its parent, so there is nothing
to restore, and the other parallel tests (xt/tt_tidy.t, xt/pl_valid.t,
t/db_dependent/00-strict.t) don't do it either. I have removed the getcwd/chdir
lines and the Cwd import (attachment replaced).

To check, I ran the whole of xt/perltidy.t in KTD with KOHA_PROVE_CPUS=6
without them: all 3373 files resolve their relative paths correctly in the
workers. The one failure is t/db_dependent/api/v1/messages.t, which is not tidy
on main (the file is not touched by this patch, it comes from bug 23998), so
the full run currently fails regardless of this patch until that file is
tidied.

Setting back to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to