https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #576 from Andrew Fuerste-Henry <[email protected]> --- Further QA thoughts/issues: - I think we can drop the confirmation patch, since you've blocked the printing of Pending non-print notices. - Claude points out that the print_notice page doesn't scrub or sanitize the notice content at all and so could allow a script in the notice content to run. This appears to be true, but I haven't gone so far as to put a script into a notice to test. - Claude also complained that t/db_dependent/Koha/Notice/Message.t passes regardless of what IndependentBranches is set to. I confirmed that the test still passes if I switch line 772 to "mock_preference( 'IndependentBranches', 0 );" - If the CONVERTED_TO_PRINT notice is deleted, Koha gives the error "The notice could not be converted to a print notice." when one clicks Convert To Print. I suggest removing the Convert button if the notice doesn't exist. If not that, the error message should direct the user to create the notice. - When logging conversion, you're not recording a diff of the changes to the converted notice (status and updated_on change) and the log viewer displays the action in all caps rather than sentence case ("Converted"). - More conceptually/structurally, you're logging notice conversion in the Notices log, which is otherwise only used for edits to notice templates -- the system preference reads "(Don't) Log changes to notice templates." I don't know that this is a blocker, but it's uncomfortable. It would be great to have a separate log module for recording changes to notices in the message_queue, which would want to be a separate enhancement. I wouldn't mind dropping notice conversion logging from these patches with the general expectation of creating a new logging module in the future. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
