http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10998
Bug ID: 10998
Summary: code duplication introduced by Z39.50 authority search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Bug 10096, which introduces a feature to import authority records via Z39.50,
also introduces some code duplication.
To summarize the differences:
- z3950_search.pl and z3950_auth_search.pl differ only in the input search
attributes they accept
- C4::Breeding::ImportBreeding() and C4::Breeding::ImportAuth() do mostly the
same thing
- the actual search logic in C4::Breeding::Z3950SearchAuth() and
C4::Breeding::Z3950Search() is the same; the two routines differ only in the
specific Z39.50 attributes they handle and in some details of post-retrieval
record processing. Also, Z3950SearchAuth() does not reflect the work that was
done for bug 10462.
Consequently, there is plenty of opportunity for code consolidation, as well as
adding unit tests.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
