https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |k Status|Passed QA |Failed QA --- Comment #10 from Pedro Amorim (ammopt) <[email protected]> --- Hi all, 1 small thing, steps below. Patch #2 removed modordernotes.tt, but the note links on the basket, late orders and receive pages still point to modordernotes.pl. Opening one in a new tab now shows an empty 'Receive orders from' page. To reproduce: 1) Inside KTD, create a basket with one order: $ ktd --shell k$ perl -MKoha::Acquisition::Baskets -MKoha::Acquisition::Orders -e 'my $b = Koha::Acquisition::Basket->new({ booksellerid => 1, basketname => "follow-up" })->store; Koha::Acquisition::Order->new({ basketno => $b->basketno, biblionumber => 1, quantity => 1, budget_id => 1 })->store; print "basketno=", $b->basketno, "\n"' 2) Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=<basketno> 3) Open 'Add internal note' in a new tab 4) Confirm it shows an empty 'Receive orders from' page The first patch works fine on its own, with modordernotes.tt kept as the page the links fall back to (the same way moddeliverydate.tt works for the delivery date modal). I think we should either: a) Obsolete patch #2, or b) Remove all hrefs pointing to modordernotes.pl and make modordernotes.pl POST-only (save and redirect) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
