https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951
--- Comment #9 from Martin Renvoize (ashimema) <[email protected]> --- Revised patch set: the series now uses a new no_link parameter instead of no_html. The first version passed no_html = 1 to patron-title.inc. That drops the link, but it also removes the <span class="surname">, <span class="cardnumber"> etc. wrappers around each name part. Local IntranetUserJS and IntranetUserCSS often rely on those classes, so hiding them would break local customisations. Patches: 1. Add a no_link parameter to patron-title.inc. It only drops the link and keeps the spans. Output is unchanged for anything that does not pass it. 2. Use no_link in the h1 of the pages that are already about that patron (notices, account, statistics, routing lists, API keys, housebound, modify patron). 3. Switch the circulation headings from Bug 43220 and Bug 43866 (and the circ-menu sidebar heading) from no_html to no_link, so their spans come back and the markup matches what it was before those bugs. 4. Switch the h1 of the patron details page and the permissions page from no_html to no_link, so every patron heading is consistent. Breadcrumbs are unchanged and still link to the patron. no_html is still used where plain text is required, such as <title> and inside links or buttons. Proposed guideline, for discussion: link the patron name when it points to a patron the user is not currently viewing (tables, notes, alerts, breadcrumbs). Show it as plain text, with its spans, in the heading or legend of a page that is already about that patron. I rendered patron-title.inc in KTD to check the three cases. Default output is unchanged, no_link=1 gives the same spans without the <a>, and no_html=1 gives bare text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
