https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43955

            Bug ID: 43955
           Summary: POS receipt links open an intermediate page instead of
                    printing directly
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Point of Sale
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]
  Target Milestone: ---

Since Bug 41705, pos/printreceipt.tt only prints on load when the URL has
autoprint=1. Otherwise it shows the receipt with a "Print receipt" button and a
"Close" button.

Only the automatic flow (FinePaymentAutoPopup on, redirect from pos/pay.pl)
passes autoprint=1. The links that explicitly ask for a receipt do not, so
clicking "Print receipt" now opens an intermediate page and a second click is
needed before the browser print dialogue appears. Before Bug 41705 these links
printed straight away, because the page included slip-print.inc.

The links without autoprint=1 are:
- pos/pay.tt: the "Print receipt" button in the "Payment received" alert (shown
when FinePaymentAutoPopup is off)
- pos/register.tt: the receipt action in the cash register transaction history
(window.open)
- members/boraccount.tt: the receipt action in the patron's Accounting
transactions table

Libraries who do not want the automatic receipt pop-up after patron account
payments cannot get the old behaviour back: setting FinePaymentAutoPopup to
"Do" removes the extra step in POS but also turns on the automatic pop-up in
members/pay.pl and members/paycollect.pl.

Proposed fix: add autoprint=1 to those three links, so that explicitly asking
for a receipt prints it directly regardless of FinePaymentAutoPopup. The manual
Print and Close buttons stay for anyone who opens the receipt page without
autoprint. The Email receipt actions are unaffected.

To test:
1. Enable EnablePointOfSale and UseCashRegisters and create a cash register.
Set FinePaymentAutoPopup to "Don't show".
2. In Point of Sale, complete a sale. In the "Payment received" alert click
"Print receipt".
   => The receipt opens in a new tab and the print dialogue appears straight
away. (Before the patch: a page with a Print button.)
3. In the cash register's transaction history, use the print receipt action on
a transaction. Same expectation.
4. In a patron's Accounting > Transactions, use the print receipt action on a
payment. Same expectation.
5. Set FinePaymentAutoPopup to "Do" and complete a POS sale: the receipt still
prints automatically, as before.

Related: Bug 41705, Bug 43402.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to