https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43028
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #37 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Nick, your feedback turned up two real problems, now fixed in two follow-up patches (rebased onto current main, signoffs on the existing patches unchanged). 1. Overlaying onto a record that is already corrupt in the catalog: the record being replaced was decoded outside the per-record isolation, so one bad catalog record made the whole commit die and left the batch stuck in 'importing', where it could be neither finished nor reverted. It is now read through Koha::Biblio::Metadata->record (repairing what can be repaired); records that cannot be read are flagged 'error' with the reason, any other unexpected failure is isolated and logged per record, and the batch ends 'imported'. Checked end to end with three corrupted catalog records (blank datafield, control character, truncated XML): 2 overlaid, 1 flagged, batch imported, and revert restored the original titles. 2. Staging a MARCXML file with an unparseable record: RecordsFromMARCXMLFile kept the record across iterations, so the previous record was staged twice, and an unparseable first record dropped all the rest. Each record is now read on its own, errors are reported, and the next record is still read. Note that your control-character file is not well-formed XML, so the parser can only report it and carry on where it can. Both have tests (t/db_dependent/ImportBatch.t, t/ImportBatch.t); koha-qa is clean. Back to Signed Off for QA. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
