http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21686|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <[email protected]> --- Created attachment 21825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21825&action=edit [PASSED QA] Bug 10843: the DateTime->add method takes a scalar, not undef Test plan: 1) set an empty string for the ReservesMaxPickUpDelay pref 2) place a hold on an item 3) check in the item 4) click on "Print and confirm" 5) an error occurs > The 'days' parameter (undef) to DateTime::Duration::new was an 'undef' 6) apply the patch 7) repeat steps 1 to 4 8) the error does not occur anymore. Signed-off-by: Srdjan <[email protected]> Signed-off-by: Katrin Fischer <[email protected]> An empty string didn't do it for me, I had to set the variable for the systempreference to NULL. I am not sure if this can happen when editing from the interface, but this change should not have any ill side effects and it has unit tests! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
