https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42790
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |[email protected] | |k --- Comment #28 from Pedro Amorim (ammopt) <[email protected]> --- Hi all, 1 blocker and 2 small pointers. Blocker: the new Cypress component spec fails k$ yarn cypress run --component --spec t/cypress/component/ExtendBookingModal_spec.ts Non-blockers, since we're here: 1) The cancellation reason is shown unescaped in the status badge. This was already the case before this series, but it now lives in the new bookings/common.js (statusBadge). Setup: 1) Go to 'Administration' > 'Item types', edit 'BK', tick 'Bookable', click 'Save changes' 2) Go to: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 3) Click 'Place booking': 'Patron': 'koha', 'Pickup at': 'Centerville', 'Item': '3999900000001', pick future dates, click 'Submit' Steps: 1) Go to: http://localhost:8081/cgi-bin/koha/bookings/list.pl?biblionumber=1 2) Click 'Cancel', type '<b>BOLD</b>' as the cancellation reason, click 'Yes, cancel booking' 3) Click 'Include cancelled' 4) Notice the badge shows 'Cancelled: BOLD' in bold instead of the literal text 2) circulation.tt includes the place/extend booking modals and their JS even when EnableBooking is disabled (moremember.tt checks the preference) 1) Set 'EnableBooking' to 'Disable', click 'Save all Circulation preferences' 2) Go to: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3) View source, search 'extendBookingModal' => found 4) Same on: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 => not found -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
