https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43777
Adolfo RodrÃguez Taboada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #11 from Adolfo RodrÃguez Taboada <[email protected]> --- Following up on point 2: svc/bib is one of the places that still deals with problematic records the old way, and it was not adapted here. In fetch_bib (svc/bib, line 77), when metadata_record throws Koha::Exceptions::Metadata::Invalid, it still calls $biblio->metadata->record_strip_nonxml, which this bug removed (only Koha::Authority->record_strip_nonxml remains). So: - Recoverable records never reach that branch any more, because metadata_record already returns the repaired record. As a result the invalid-metadata header is never sent, and the advanced editor (koha-backend.js, GetRecord) no longer shows "Record had encoding issues, please switch to the basic editor to view details". OAI and addbiblio.pl were adapted to check object_messages, but svc/bib was not. - Unrecoverable records now die with a call to a method that no longer exists. They already failed before, so the practical result is the same, but the error is now a missing method. A possible fix in fetch_bib would be to drop the record_strip_nonxml call (returning a proper error for unrecoverable records), and to set invalid_metadata when $biblio->metadata->object_messages is not empty, as Koha::OAI::Server::Repository->get_biblio_marcxml does. Have a nice day. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
