https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43962
--- Comment #10 from Martin Renvoize (ashimema) <[email protected]> --- Patches attached. This bug depends on 43957 (currency digits and the OutgoingRounding preferences) and 43958 (the shared JavaScript currency helper). What it does: acquisitions now rounds with one rule in Perl, SQL and JavaScript, driven by OutgoingRoundingTiming and OutgoingRoundingMode, with an optional override per vendor (two new nullable columns on the vendor, editable on the vendor form and in the API). When a vendor setting is empty the system preference is used. Timing values: - line: round the unit price, then multiply by the quantity. This is what OrderPriceRounding = nearest_cent did. - total: multiply, then round the line total once; totals are the sum of the rounded line totals. For 3 copies at 3.333333 this gives 10.00, matching a vendor invoice, where "line" gives 9.99. - none: nothing is rounded. Also: fund and budget totals used SQL that truncated (0.829 became 0.82) where the screens rounded; they now use the same rule. The new order form, basket, invoice, receiving, spent and ordered pages, the fund reports and the basket group PDF follow it, and two places that rounded a quantity no longer do. OrderPriceRounding, get_rounded_price and get_rounding_sql are removed. Notes for the release notes: - The settings are read when amounts are calculated, so changing a preference or a vendor setting changes how existing orders and the fund "spent" and "ordered" figures are calculated. No stored prices change. - The tax values stored on orders placed or received from now on follow the timing. Existing rows are not rewritten. - OrderPriceRounding is removed (its value was migrated to OutgoingRoundingTiming in bug 43957). The descriptions of bugs 43957 and 43960 still mention IncomeRoundingTiming, which no longer exists: income amounts are always rounded when stored. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
