https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43402
--- Comment #12 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 210185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210185&action=edit Bug 43402: (QA follow-up) Say that a fee was written off, not that a payment was received The notification offered after a payment is taken on the patron account pages said "Payment received" for a write off too, which could make staff worry that they had entered a payment rather than a write off. pay.pl and boraccount.pl now look up the credit by its payment_id, on the patron's account, and give its type to the template, which says "Fee written off" for a write off and keeps "Payment received" otherwise. As a result the notification, and the links to its receipt, are only shown for a credit that is on the account of the patron being looked at, instead of for any payment_id. To test: 1. Set FinePaymentAutoPopup to "Do not show" 2. Write off a fee, individually (Write off) and by selecting charges (Write off selected) => "Fee written off", with Print/Email receipt 3. Pay a fee, individually and by selecting charges => "Payment received", with Print/Email receipt 4. Open members/pay.pl or members/boraccount.pl with the payment_id of another patron's payment => No notification 5. Run the Cypress spec t/cypress/integration/Circulation/PaymentReceiptAlert_spec.ts Sponsored-by: Martin Renvoize <[email protected]> Co-Authored-By: Claude Sonnet 5.5 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
