https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41921
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #228 from Pedro Amorim (ammopt) <[email protected]> --- Hi all, blockers 1 and 3 are fixed, thanks Lucas. Blocker: xt/api.t fails on the new routes 1) yarn api:bundle 2) prove xt/api.t 3) Notice: - 'reports' tag is not in the top-level tags list (GET /reports/jobs, GET /reports/jobs/running, POST /reports/jobs/{job_id}/cancel) - '400 response tests' fails on the same routes (missing invalid_query, DefaultResponse used instead of a 400 error) Not blocking, but worth a look (up to you): - On upgrade, every report run still stops at 'How would you like to run this report?', even with bug 42108 applied: existing reports get run type 'Both', so the choice shows until each report is edited. Upgrading with ReportsRunInBackground set to 'never' (keeping 'user_choice' for new installs) would keep current behavior, and have the new feature be 'opt-in', as how it's usually done. - list() and list_running() in Koha/REST/V1/Reports/Jobs.pm now duplicate the LimitReportsBy filtering (WET). A shared helper (e.g. Koha::Reports->filter_by_accessible($patron)) would keep them in sync; blocker 3 was exactly one of them missing it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
