https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42000
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|[email protected] |[email protected] |y.org | --- Comment #3 from Katrin Fischer <[email protected]> --- I like the idea of this patch adding more consistency to the display. But there are a few small things to fix: >From QA tools: 1) Patch set is not tidy. 2) We are missing a filter. 3) Fallback for staff users without permissions I notice that we always show the holds, but the bookings will only show if the user has the permission to manage bookings. I think we should have an unlinked "text only" fallback if permissions are lacking here: [% ELSE %] <span>Holds ([% SEARCH_RESULT.biblio_object.holds.count | html %])</span> [% END %] + [% IF Koha.Preference('EnableBooking') && CAN_user_circulate_manage_bookings && SEARCH_RESULT.has_bookable_items %] + | <a href="/cgi-bin/koha/bookings/list.pl?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]#bookings">Bookings ([% SEARCH_RESULT.future_bookings_count | html %])</a> + [% END %] It's also a question if the count should not be implemented as an object method like the holds count? It will probably be useful in more than this one spot, thinking of the detail page for example. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
