https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383
--- Comment #140 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Matt Blenkinsop from comment #139) > All the points above are addressed, thanks Tomas. > > I'm getting a small merge conflict when applying to a fresh main so that > will need rebasing > > Two final points from the follow-up patches: > > 1) Checkins.pm line 131 - I think we need the same guard here as in > Checkouts.pm. The eval with render_invalid_parameter_value pattern prevents > a 500 error if there is a difference in timezone or fractions of a second > that passes the swagger checks > > 2) Main.vue line 707 onResolveClaimFromRow doesn't clear the activeModalItem > before showing the modal - the modal would stay open until _advanceModal is > called. The logic here is also nearly identical to onResolveClaimFromModal - > could these be combined? Please check. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
