https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42180
--- Comment #21 from Katrin Fischer <[email protected]> --- Note to myself: Running yarn build first helps to make the tests pass. (In reply to Pedro Amorim (ammopt) from comment #19) > (In reply to David Nind from comment #18) > > Questions: > > 1. Is there a reason that it shows the userid instead of the name? > > Yes, because the userid is what is saved and utilized by the SIP Server. > Can be discussed further of course but that was the original thinking. > > > 2. Was limiting the lookup to only valid staff userid's in scope for this > > bug? > > (For ILL, you can only search for patrons in the ILL patron category. > > Good question, there was no clear scope per say. It's not included for now > but can easily be done so with a follow-up. I am not sure what a valid user id would be in that case. Maybe a patron with circulate permission? But I am not sure if there are not cases where SIP would be used with other permissions (maybe for paying fines?). I don't think this is a blocker. I think this is definitely an improvement, but I wonder why we are not using the standard patron search with the modal? The auto-complete version might proof difficult in big databases (smith) and also because it only searches by "starts-with" and not "contains" it seems. Example: schnei works, but nei doesn't. (Schneider, Nicole). It's positive that the home library shows. I think it might be "good enough" for this use case for now as you are unlikely to name your self check user "smith" ;), but it might not be a good best practice for other pages/situations -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
