https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42432
--- Comment #10 from Martin Renvoize (ashimema) <[email protected]> --- Thanks for your patience with the tests, David. I've been able to reproduce your failures and they were a problem in the spec, not in the fix. The checkout rows are loaded asynchronously. The spec ticked 'Override' as soon as the table element appeared, before the on-hold row had been rendered, so the override handler had no on-hold row to reveal. The row then arrived still hidden and the 'Renew' checkbox could not be checked ("not visible because its parent span.renewals-allowed-on_reserve has display: none"). There was also a flaky failure in teardown: renewing makes the page reload the table via Ajax, and the spec deleted the checkout while that request could still be in flight. Changes to the spec: - Wait for the on-hold row to exist before ticking 'Override'. - Leave the page before deleting the sample data, and do the cleanup of the second checkout in afterEach. Both patches are rebased onto current main. With them applied the spec passed 5/5 runs before the rebase and 3/3 after it (in KTD, via: yarn cypress run --spec t/cypress/integration/Circulation/OnHoldDueDate_spec.ts). With the first patch reverted the on-hold test fails with: expected '2099-05-05 23:59' to equal '2099-06-15 23:59', and the other test still passes, so it does catch the regression. Note that after pulling a newer main you will need to run updatedatabase.pl (or reset_all) in KTD, otherwise Cypress is served the web installer page and the login step fails. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
