https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383
--- Comment #201 from Matt Blenkinsop <[email protected]> --- Created attachment 210510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210510&action=edit Bug 42383: (QA follow-up) Hide the confirmation modal while resolving a claim The 'Resolve claim' button of a row in the checkins table opens the resolve claim modal without hiding the confirmation modal, so both are displayed until the next one is shown. The 'Resolve claim (Y)' button of the confirmation modal did hide it, in a near copy of the same handler, but it did not come back when the resolve claim modal was closed. This patch addresses point 2 of comment #139. Both buttons, and the 'Resolve claim' link of the check-in messages, use the same handler: - The confirmation modal is hidden while the resolve claim modal is open, and a new check-in does not bring it up meanwhile - When the resolve claim modal is closed or the claim resolved, the next pending item is shown, as after any other modal action The Cypress test checks the confirmation modal is hidden while resolving, and is shown again for the claim still pending. Test plan: 1. Set ClaimReturnedLostValue to any lost value, and leave AutoClaimReturnStatusOnCheckin empty 2. Check out two items to a patron, and mark both as claims returned from the patron's checkouts table 3. Check in both items on the check-in page => SUCCESS: The 'Item was claimed returned' modal is shown 4. Click 'Resolve claim' on the row of the first item checked in => FAIL: The 'Item was claimed returned' modal is still displayed 5. Apply this patch 6. Run: $ ktd --shell k$ yarn js:build 7. Repeat 2 to 4 => SUCCESS: Only the 'Resolve return claim' modal is displayed 8. Resolve the claim => SUCCESS: The 'Item was claimed returned' modal is shown for the other item 9. Run: k$ yarn cypress run --spec t/cypress/integration/Circulation/Checkin_spec.ts => SUCCESS: Tests pass! 10. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Matt Blenkinsop <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
