https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42335
Brendan Lawlor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Brendan Lawlor <[email protected]> --- 1. This doesn't have a filter: [% t('items in cart') %] so xt/find-missing-filters.t fails. It would be fixed with [% t('items in cart') | html %] 2. The accessible name has confusing grammar when there are '(1) items in cart' I think this could be resolved by leading with the word Cart, so no plural form is needed and the link starts with it's purpose, so it's better for users using a screen reader. <a class="nav-link" href="#" id="cartmenulink"> <i class="fa fa-shopping-cart" aria-hidden="true"></i> <span class="visually-hidden">[% t('Cart') | html %]</span> <span id="basketcount"><(0)</span> </a> 3. The first commit removes title="Cart", which could be considered a useful tooltip for sighted mouse users. If we add it back it should be added to the <a> element rather than on the <i> element it was on before. 4. In reply to Owen's comment, before this patch (0) would show after emptying the cart, so it could be considered consistent, event though it is different that it starts with (0) with this patch. The js wraps the count in a <span> so the first hard coded (0) is styled slightly differently, appearing a tiny bit larger. The JS probably doesn't need to add the extra span in this case. 1 is a blocker, 2-4 are recommended -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
